Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying default CollectionFormat #841

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Allow specifying default CollectionFormat #841

merged 1 commit into from
Mar 21, 2020

Conversation

Dreamescaper
Copy link
Contributor

fixes #840

What kind of change does this PR introduce?

Allow specifying default CollectionFormat in RefitSettings.

What is the current behavior?

CollectionFormat is needed to be set for each query parameter if non-csv is needed.

What is the new behavior?

You can specify CollectionFormat in RefitSettings, which will be applied unless explicitly specified in QueryAttribute.

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@clairernovotny
Copy link
Member

This looks good. Can you please rebase/resolve conflicts and I can merge?

@Dreamescaper
Copy link
Contributor Author

Done!
I see that I have changes in RefitStubs (they are added on build), I assume they are caused by #843 .
Let me know if I should revert them.

@clairernovotny clairernovotny merged commit 90d8492 into reactiveui:master Mar 21, 2020
@Dreamescaper Dreamescaper deleted the default_collection_format branch April 5, 2020 12:46
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Allow specifying default CollectionFormat in RefitSettings
2 participants