fix issue experienced in #649 #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found moving the RefitInternalGenerated using declaration to the top allowed my 3.1 project to build without the errors found in bug reactiveui#649
RefitInternalGenerated using declaration moved
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Moves the RefitInternalGenerated using declaration to the top of the GeneratedInterfaceStubTemplate.mustache file with others
What is the current behavior?
More detail can be found in #649. The generated template cannot find RefitInternalGenerated or Preserve and other classes, properties and attributes related to the namespace.
What is the new behavior?
I found moving the using allowed my 3.1 project to build without the errors.
What might this PR break?
I don't believe this change will cause anything to break. I have not seen anything else within the project with the name RefitInternalGenerated.
Please check if the PR fulfills these requirements
Other information:
First PR for me to this project. If I am wrong about the requirements for this change being complete through existing tests and documentation of this file please direct me and I will correct.