Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jsx in depth #137

Merged
merged 31 commits into from
Apr 3, 2020
Merged

Jsx in depth #137

merged 31 commits into from
Apr 3, 2020

Conversation

smetzdev
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jan 16, 2020 •
edited
Loading

Deploy preview for de-reactjs ready!

Built with commit b3fc4dc

https://deploy-preview-137--de-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request Jan 16, 2020
Closed
91 tasks
@smetzdev
Copy link
Contributor Author

Not completed :O

@ph1p
Copy link
Member

ph1p commented Jan 17, 2020

Not completed :O

Sorry ^^ I changed the label

@smetzdev
Copy link
Contributor Author

Quick question: How would you folks translate "String Literal" or "unescaped HTML" ?

@ph1p
Copy link
Member

ph1p commented Jan 19, 2020

Quick question: How would you folks translate "String Literal" or "unescaped HTML" ?

I don't think we have to translate "String Literal".
String Literal -> String-Literal

"unescaped HTML" - Maybe we can write something like "nicht escaptes HTML". https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/unescape - This is an old method documentation, but in the first paragraph they also write "escapte".

@smetzdev
Copy link
Contributor Author

I agree. How about "unformatiert" or "nicht ausgeschlossen" or "unverändert" vor "unescaped" ?

@smetzdev
Copy link
Contributor Author

completed - needs review 🧐:)

@smetzdev
Copy link
Contributor Author

beep

@ph1p
Copy link
Member

ph1p commented Feb 17, 2020

Is this PR ready for review? You can add me, if you want, in the top right corner, so you don't have to write "beep" :)

@smetzdev smetzdev requested a review from ph1p February 17, 2020 20:25
@smetzdev
Copy link
Contributor Author

Indeed it is :) (Beep seemed kinda cool)

ph1p
ph1p approved these changes Feb 17, 2020
View reviewed changes
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
@ph1p ph1p self-requested a review February 17, 2020 21:02
@ph1p ph1p added needs review from author First review completed. All changes are processed and a final review is required. and removed completed - needs review 🧐 labels Feb 17, 2020
Sascha Metz and others added 15 commits February 18, 2020 06:50
@ph1p
Update content/docs/jsx-in-depth.md
1517fda 
Accept suggestions ins line 438

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
9dee1fb 
Accept suggestions ins line 429

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
2113d98 
Accept suggestions ins line 409

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
3805afe 
Accept suggestions in line 224

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
05412e7 
Accept suggestions in line 378

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
1581dea 
Accept suggestions in line 325

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
629fdde 
Accept suggestions in line 294

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
cb29f55 
Accept suggestions in line 212

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
ab90799 
Accept suggestions in line 178

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
363e56c 
Accept suggestions in line 154

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
098d055 
Accept suggestions in line 149

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
d10eba9 
Accept suggestions in line 288

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
4eb7cf6 
Accept suggestions in line 270

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
0bd099e 
Accept suggestions in line 250

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
74ce757 
Accept suggestions in line 237

Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/jsx-in-depth.md
73d79e1 
Accept suggestions in line 388

Co-Authored-By: Phil <phil@capshake.com>
@smetzdev
Copy link
Contributor Author

Think we're already done here?

@ph1p
Copy link
Member

ph1p commented Apr 3, 2020

Top! 👍

@ph1p ph1p merged commit ada69e3 into reactjs:master Apr 3, 2020
@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Apr 3, 2020
@smetzdev
Copy link
Contributor Author

smetzdev commented Apr 5, 2020

Thanks for merging and stay healthy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph1p ph1p ph1p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smetzdev @ph1p