Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 Worked on German translation of Tic-Tac-Toe Tutorial #174

Merged
merged 3 commits into from Apr 1, 2021
Merged

🚧 Worked on German translation of Tic-Tac-Toe Tutorial #174

merged 3 commits into from Apr 1, 2021

Conversation

liza-kl
Copy link

@liza-kl liza-kl commented Nov 9, 2020

#34

I worked a little bit on the Translation, might continue in the next couple of days and then proof-read it :)
Cheers

@vercel
Copy link

vercel bot commented Nov 9, 2020

@liza-kl is attempting to deploy a commit to the Facebook Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@miku86 miku86 self-requested a review January 7, 2021 18:34
@miku86
Copy link
Member

miku86 commented Jan 7, 2021

Hey folks,

I will review it on Saturday.

@liza-kl, thanks for your awesome efforts,
we really appreciate it!

content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
content/tutorial/tutorial.md Outdated Show resolved Hide resolved
Copy link
Member

@miku86 miku86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Lisa,

vielen Dank für deine tolle Arbeit! :)

Ich habe ein paar Bemerkungen/Empfehlungen gemacht.

Bitte schau dir jede Bemerkung/Empfehlung an und stimme ihr zu (Commit suggestion) oder schreib einen Kommentar, damit wir uns darüber austauschen können. Du kannst auch einen großen Batch an Commits machen

Ich denke, das war der letzte große Brocken der Dokumentation.

Grüße
Michael

@miku86
Copy link
Member

miku86 commented Feb 8, 2021

Hey @liza-kl,

hope you're doing well!

It would be cool to keep the ball rolling.
Please let us know if you are interested in having a look at this.
No hard feelings if you're not, just to know the current situation 🙂.

Greetings
Michael

@pop1989bb
Copy link
Contributor

pop1989bb commented Mar 5, 2021

Guten Morgen @liza-kl, @miku86
ich würde bei der Vervollständigung etc. auch unterstützen wollen, bin aber (als seltener GitHub-Nutzer) etwas verwirrt, weil bei mir immer die Meldung kommt, dass ich mich nicht in einem Branch befinde. Falls ich helfen kann, lasst es mich gerne wissen.

@miku86
Copy link
Member

miku86 commented Apr 1, 2021

Hey folks,

I just approved my own suggestions, so that we can finish this task.

@ph1p Can we ignore the missing Vercel deployment check?

@pop1989bb Sorry for missing your reply. You can simply create your own pull requests after this current pull request will be merged. Reach out if you need some help.

Greetings
Michael

@ph1p
Copy link
Member

ph1p commented Apr 1, 2021

Hmm the vercel bug is new to me, but I think we can merge the changes for now since the target branch is not the main branch anyway.
Looks good to me! 👍

@ph1p ph1p merged commit bb2b352 into reactjs:task/translating-tutorial Apr 1, 2021
@ph1p ph1p mentioned this pull request Apr 1, 2021
91 tasks
@liza-kl liza-kl deleted the task/translating-tutorial branch May 13, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants