New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 Worked on German translation of Tic-Tac-Toe Tutorial #174
🚧 Worked on German translation of Tic-Tac-Toe Tutorial #174
Conversation
@liza-kl is attempting to deploy a commit to the Facebook Open Source Team on Vercel. A member of the Team first needs to authorize it. |
Hey folks, I will review it on Saturday. @liza-kl, thanks for your awesome efforts, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Lisa,
vielen Dank für deine tolle Arbeit! :)
Ich habe ein paar Bemerkungen/Empfehlungen gemacht.
Bitte schau dir jede Bemerkung/Empfehlung an und stimme ihr zu (Commit suggestion
) oder schreib einen Kommentar, damit wir uns darüber austauschen können. Du kannst auch einen großen Batch an Commits machen
Ich denke, das war der letzte große Brocken der Dokumentation.
Grüße
Michael
Hey @liza-kl, hope you're doing well! It would be cool to keep the ball rolling. Greetings |
Hey folks, I just approved my own suggestions, so that we can finish this task. @ph1p Can we ignore the missing Vercel deployment check? @pop1989bb Sorry for missing your reply. You can simply create your own pull requests after this current pull request will be merged. Reach out if you need some help. Greetings |
Hmm the vercel bug is new to me, but I think we can merge the changes for now since the target branch is not the main branch anyway. |
#34
I worked a little bit on the Translation, might continue in the next couple of days and then proof-read it :)
Cheers