-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
translate conditional rendering page #21
translate conditional rendering page #21
Conversation
Deploy preview for de-reactjs ready! Built with commit d70b84f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :) Can you please update also the examples?
Hi @ph1p, I really appreciate your suggestions. I've updated the PR with your suggested wording and added codepen examples. Unfortunately the translated codepens don't include CSS like the english ones because .css files currently aren't recognized by the codepen generator. I checked a couple of other language translation repos how they deal with this problem -> They just don't translate the code examples. What's your opinion about how we should handle this issue? |
Translating code examples is more consistent in my opinion, but if it is technically currently not possible, then we should skip it for now and focus on the things that are still open.. |
Hi! 👋
This PR contains the translation of the 'Conditional Rendering' page.
I left the codepen links untouched because I only translated comments and display text into german so that the difference might not have a huge impact on the reader.
If you find that inappropriate there are two possible solutions coming to my mind: