Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: Advanced Guides > Refs and the DOM #86

Merged
merged 9 commits into from
Feb 12, 2019

Conversation

Darking360
Copy link
Collaborator

@Darking360 Darking360 commented Feb 5, 2019

Translation of Advanced Guides: Refs and the DOM

Related: Original issue: Spanish Translation Progress

To Do:

  • Finish first translation draft

  • Check translation

  • Check grammar and orthography

  • Submit final

@Darking360
Copy link
Collaborator Author

Darking360 commented Feb 6, 2019

Hey guys! Quick question, the code examples, should they also be translated? Or only the comments inside them? 🤔

CC: @dmoralesm @carburo @alejandronanez

@alejandronanez
Copy link
Member

Hey @Darking360, thanks for asking.

You should translate code comments, that's it - everything else, (variable names, JSX, component names, props) should remain untouched!

@Darking360 Darking360 changed the title [WIP] Translate: Advanced Guides > Refs and the DOM Translate: Advanced Guides > Refs and the DOM Feb 9, 2019
@Darking360
Copy link
Collaborator Author

Greetings guys! 💪

I just finished the translation, would you please check it out? Let me know for any changes 🙏 🚀

CC: @alejandronanez @carburo @dmoralesm

Copy link
Member

@alejandronanez alejandronanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Darking360, looks solid!

Just requested one more change before merging (literally, it's just a .). I'm approving this PR to get things moving!


You can pass callback refs between components like you can with object refs that were created with `React.createRef()`.
Puedes pasar una referencia mediante callback entre componentes tal como puedes con los objetos de referencias creados con `React.createRef()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Puedes pasar una referencia mediante callback entre componentes tal como puedes con los objetos de referencias creados con `React.createRef()`
Puedes pasar una referencia mediante callback entre componentes tal como puedes con los objetos de referencias creados con `React.createRef().`

@Darking360
Copy link
Collaborator Author

Greetings @alejandronanez 🌞

I just updated the PR and add the missing dot, if you could take a look at it would be great 💪 Let me know if anything changes.

CC: @carburo @dmoralesm

@carburo carburo merged commit dce2349 into reactjs:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants