Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles ObjectTypeSpreadProperty in object type annotation. #593

Merged
merged 8 commits into from
May 28, 2022

Conversation

imdreamrunner
Copy link
Contributor

This PR is attempting to fix #449

With the fix, react-docgen is able to support the following senario

type OtherFruits = { orange: string };
type props = { apple: string, banana: string, ...OtherFruits };

Copy link
Collaborator

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot

@danez danez added the bug label May 18, 2022
src/utils/__tests__/getFlowType-test.ts Outdated Show resolved Hide resolved
@danez danez merged commit 395f338 into reactjs:main May 28, 2022
danez added a commit that referenced this pull request May 28, 2022
…ions (#593)

Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
danez added a commit that referenced this pull request May 28, 2022
…ions (#593)

Co-authored-by: Daniel Tschinder <231804+danez@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Did not recognize object of type "ObjectTypeSpreadProperty"
2 participants