Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make contentLabel optional #479

Closed
bluSCALE4 opened this issue Aug 16, 2017 · 1 comment
Closed

Make contentLabel optional #479

bluSCALE4 opened this issue Aug 16, 2017 · 1 comment
Labels

Comments

@bluSCALE4
Copy link
Contributor

bluSCALE4 commented Aug 16, 2017

According to the ARIA spec, "If the label text is visible on screen, authors SHOULD use aria-labelledby and SHOULD NOT use aria-label." With that said, since the contentLabel uses aria-label, it shouldn't be required since ideally, if the label is visible on the page, then an id to that element should be provided to aria-labelledby.

https://www.w3.org/TR/wai-aria/states_and_properties#aria-label

@cycomachead
Copy link

While a more complex validation, I would support something that's either aria-labelledby OR contentLabel is required. I'm migration some existing modals to use the-modal, and this what I'll be implementing on our wrapper component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants