-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fixed] Remove required flag from contentLabel propType in Modal #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Hi @bluSCALE4, can you check if it is needed to update the docs? |
1 similar comment
1 similar comment
diasbruno
requested changes
Aug 22, 2017
README.md
Outdated
@@ -1,4 +1,4 @@ | |||
# react-modal | |||
k react-modal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use "#".
1 similar comment
Change 'set' to 'sets' in Modal.spec Update README required props section
diasbruno
approved these changes
Aug 23, 2017
Oh, my bad. Totally forgot this PR. Sorry, @bluSCALE4. I'll get this merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #479.
Changes proposed:
ARIA spec, "If the label text is visible on screen, authors SHOULD use aria-labelledby and SHOULD NOT use aria-label."
Changing contentLabel propType to not be required; reference id for aria-labelledby will now be supported.
Upgrade Path (for changed or removed APIs):
Won't affect existing code.
Acceptance Checklist:
CONTRIBUTING.md
.