Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixed] Remove required flag from contentLabel propType in Modal #480

Merged
merged 1 commit into from
Sep 20, 2017
Merged

[fixed] Remove required flag from contentLabel propType in Modal #480

merged 1 commit into from
Sep 20, 2017

Conversation

bluSCALE4
Copy link
Contributor

Fixes #479.

Changes proposed:
ARIA spec, "If the label text is visible on screen, authors SHOULD use aria-labelledby and SHOULD NOT use aria-label."
Changing contentLabel propType to not be required; reference id for aria-labelledby will now be supported.

Upgrade Path (for changed or removed APIs):
Won't affect existing code.

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@bluSCALE4 bluSCALE4 changed the title Remove required flag from contentLabel propType in Modal [fixed] Remove required flag from contentLabel propType in Modal Aug 16, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.24% when pulling 83ad71a on bluSCALE4:master into b908042 on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.24% when pulling 83ad71a on bluSCALE4:master into b908042 on reactjs:master.

@diasbruno
Copy link
Collaborator

Hi @bluSCALE4, can you check if it is needed to update the docs?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.24% when pulling 7c8085c on bluSCALE4:master into b908042 on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.24% when pulling 7c8085c on bluSCALE4:master into b908042 on reactjs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.24% when pulling c7f79b2 on bluSCALE4:master into b908042 on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.24% when pulling c7f79b2 on bluSCALE4:master into b908042 on reactjs:master.

README.md Outdated
@@ -1,4 +1,4 @@
# react-modal
k react-modal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "#".

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.24% when pulling bc7a2c0 on bluSCALE4:master into b908042 on reactjs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.24% when pulling bc7a2c0 on bluSCALE4:master into b908042 on reactjs:master.

Change 'set' to 'sets' in Modal.spec
Update README required props section
@coveralls
Copy link

coveralls commented Aug 23, 2017

Coverage Status

Coverage remained the same at 87.24% when pulling e879eff on bluSCALE4:master into b908042 on reactjs:master.

@diasbruno
Copy link
Collaborator

Oh, my bad. Totally forgot this PR. Sorry, @bluSCALE4. I'll get this merged soon.

@diasbruno diasbruno merged commit ba81894 into reactjs:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants