enable click to close in iOS (#301) #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diasbruno
requested changes
Jan 10, 2017
| } else { | ||
| this.focusContent(); | ||
| } | ||
| handleOverlayClick(event) { |
There was a problem hiding this comment.
Lint: handleOverlayClick (event).
| } | ||
|
|
||
| handleContentMouseUp = () => { | ||
| this.shouldClose = false; | ||
| handleContentClick(event) { |
There was a problem hiding this comment.
Lint: handleContentClick (event).
There was a problem hiding this comment.
Also...
Lint: static handleContentClick (event).
If a class method does not use this, it can safely be made a static function.
Hope this one is correct.
|
Sorry I don't have time to work through all the tests and this is my first time creating a pull request, perhaps I can figure it out this weekend. But so far everything works fine on my project. |
oisu
pushed a commit
to oisu/react-modal
that referenced
this pull request
Jan 24, 2017
oisu
pushed a commit
to oisu/react-modal
that referenced
this pull request
Jan 24, 2017
oisu
pushed a commit
to oisu/react-modal
that referenced
this pull request
Jan 24, 2017
claydiffrient
pushed a commit
that referenced
this pull request
Feb 1, 2017
claydiffrient
pushed a commit
that referenced
this pull request
Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[301].
Changes proposed:
Upgrade Path (for changed or removed APIs):
Acceptance Checklist:
CONTRIBUTING.md.