Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fixed] Enable click to close in iOS (#301) (#304) #313

Merged
merged 1 commit into from
Feb 1, 2017
Merged

[fixed] Enable click to close in iOS (#301) (#304) #313

merged 1 commit into from
Feb 1, 2017

Conversation

oisu
Copy link
Contributor

@oisu oisu commented Jan 24, 2017

Fixes #304.

Acceptance Checklist:

  • [✔️] All commits have been squashed to one.
  • [✔️] The commit message follows the guidelines in CONTRIBUTING.md.
  • [✔️] Documentation (README.md) and examples have been updated as needed.
  • [✔️] If this is a code change, a spec testing the functionality has been added.
  • [✔️] If the commit message has [changed] or [removed], there is an upgrade path above.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 77.007% when pulling 93e1119 on oisu:master into 75a1aa3 on reactjs:master.

@diasbruno
Copy link
Collaborator

@claydiffrient tested. this PR supersedes #304.
@oisu awesome!

@diasbruno
Copy link
Collaborator

This PR should fix #256 too.

@claydiffrient claydiffrient merged commit 6ba1c8d into reactjs:master Feb 1, 2017
claydiffrient pushed a commit that referenced this pull request Feb 26, 2017
@claydiffrient
[fixed] Enable click to close in iOS (#301) (#304) (#313)
4232477
@diasbruno diasbruno mentioned this pull request Jun 14, 2017
Merged
5 tasks
This was referenced Jan 8, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 27, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2021
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@kamalaknn kamalaknn mentioned this pull request Nov 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oisu @coveralls @diasbruno @claydiffrient