-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecation warning in react 15.6.0 about React.DOM.noscript #410
Conversation
Hello @diasbruno , I wasn't aware of that PR, your solution is surely better on the long-term, I wanted just to get rid of a deprecation notice! :P |
Yeah, that's ok. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you just need to remove the cross-env
and we are good to make a release with this. Thank you.
@@ -14,7 +14,7 @@ | |||
}, | |||
"scripts": { | |||
"start": "./node_modules/.bin/webpack-dev-server --inline --host 127.0.0.1 --content-base examples/", | |||
"test": "NODE_ENV=test karma start" | |||
"test": "cross-env NODE_ENV=test karma start" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is out of scope.
While the warning about React.DOM.noscript is gone, there is still a warning related to React.DOM.div. Both are related to the new react-dom-factories depreciation. It's coming from this. You can fix this by modifying lib/components/ModalPortal.js:
New warning
Previous Warning
|
Released |
Thank you! Sorry but I couldn't reply earlier! |
Done! :D |
As the title, this change remove the soon-will-be-deprecated use of React.DOM factories with the new drop-in package
react-dom-factories
instead.I also added
cross-env
package to be able to run tests on windows.Upgrade Path (for changed or removed APIs):
Nothing needed.
Acceptance Checklist:
CONTRIBUTING.md
.