Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React.DOM.noscript Warning #411

Closed
andrewjmead opened this issue Jun 14, 2017 · 6 comments
Closed

React.DOM.noscript Warning #411

andrewjmead opened this issue Jun 14, 2017 · 6 comments
Labels
enhancement
Milestone
1.9

Comments

@andrewjmead
Copy link

First up, thanks for helping push this library forward!

Just wanted to make you aware of this new warning as I didn't see an open issue about it. Hopefully this will be of some help.

Summary:

As of React 15.6, there is a deprecation warning when accessing React.DOM factory helpers. Here's the warning in full:

Warning: Accessing factories like React.DOM.noscript has been deprecated and will be removed in v16.0+. Use the react-dom-factories package instead.  Version 1.0 provides a drop-in replacement.

The usage can be seen here: dist/react-modal.js line 173

Steps to reproduce:

  1. Use the latest React version (15.6.0) with the latest React-Modal version (1.9.4).
@diasbruno
Copy link
Collaborator

diasbruno commented Jun 14, 2017 •
edited
Loading

Hi @andrewjmead, there are PR #410 (what you are looking for) and #395. Do mind review both PRs?

@diasbruno diasbruno added this to the 1.9 milestone Jun 14, 2017
@andrewjmead
Copy link
Author

andrewjmead commented Jun 14, 2017 •
edited
Loading

Yes. This is my fault. I looked though the issue list, but I failed to look though the PR list.

It might be a good idea to get #410 in while work on v1 continues. I can test the changes on v14 tonight.

@diasbruno
Copy link
Collaborator

Awesome. I'll release a new version with #410.

@diasbruno
Copy link
Collaborator

Thank you so much @andrewjmead! Released v1.9.6.

@andrewjmead
Copy link
Author

Very cool. Thanks for your work. I've been using react-modal for years and would love to get a little more involved. See you around!

@diasbruno
Copy link
Collaborator

diasbruno commented Jun 15, 2017 •
edited
Loading

Awesome. Appreciate your help. We are close to get v2.0.0 merged, I'm trying to get the last PRs reviewed and merged to finally merge #412.
I'm just passing a lint on #412, hope we can get it today.

odegroot added a commit to odegroot/factorio-calc that referenced this issue Jul 8, 2017
@odegroot
Resolve deprecation warning by updating react-modal
87ddee2 
    Warning: Accessing factories like React.DOM.noscript has been deprecated and will be removed in v16.0+. Use the react-dom-factories package instead.  Version 1.0 provides a drop-in replacement. For more info, see https://fb.me/react-dom-factories
    printWarning @ react.js:2277
    lowPriorityWarning @ react.js:2296
    3.Object.keys.forEach.React.DOM.(anonymous function) @ react.js:298
    Modal_render @ react-modal.js:203

reactjs/react-modal#411
odegroot added a commit to odegroot/factorio-calc that referenced this issue Jul 8, 2017
@odegroot
Resolve deprecation warning by updating react-modal
9402cfc 
    Warning: Accessing factories like React.DOM.noscript has been deprecated and will be removed in v16.0+. Use the react-dom-factories package instead.  Version 1.0 provides a drop-in replacement. For more info, see https://fb.me/react-dom-factories
    printWarning @ react.js:2277
    lowPriorityWarning @ react.js:2296
    3.Object.keys.forEach.React.DOM.(anonymous function) @ react.js:298
    Modal_render @ react-modal.js:203

reactjs/react-modal#411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
2 participants
@diasbruno @andrewjmead