-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[change] deprecate getParentElement in favor of local element. #440
Open
diasbruno
wants to merge
1
commit into
reactjs:master
Choose a base branch
from
diasbruno:feature/deprecate-get-parent-element
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[change] deprecate getParentElement in favor of local element. #440
diasbruno
wants to merge
1
commit into
reactjs:master
from
diasbruno:feature/deprecate-get-parent-element
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diasbruno
force-pushed
the
feature/deprecate-get-parent-element
branch
from
June 25, 2017 04:59
75c4ba2
to
efb0954
Compare
diasbruno
changed the title
[feature] deprecate getParentElement in favor of findDOMNode.
[feature] deprecate getParentElement in favor of local element.
Jun 25, 2017
1 similar comment
diasbruno
force-pushed
the
feature/deprecate-get-parent-element
branch
from
June 27, 2017 16:30
efb0954
to
376c4e6
Compare
1 similar comment
diasbruno
force-pushed
the
feature/deprecate-get-parent-element
branch
from
June 29, 2017 00:27
376c4e6
to
c5b148d
Compare
1 similar comment
diasbruno
changed the title
[feature] deprecate getParentElement in favor of local element.
[change] deprecate getParentElement in favor of local element.
Jul 6, 2017
Hi! Any plan to get this merged in the short term? |
Hi @adrianq, I don't know, I believe it still needs some tests and It's also a breaking change, so I'm not sure. |
If you have some time you can review this PR. :) |
This patch will give us the ability to place the modal in any place in the react tree. Each modal can handle its own clean up. Test case was written by @restrry [b9a3415](mshustov@b9a3415).
diasbruno
force-pushed
the
feature/deprecate-get-parent-element
branch
from
September 30, 2017 15:43
c5b148d
to
4d2ff12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep things simple, each Modal can be placed on any level
of the react's tree and it will do a proper clean up when it's
time to unmount the component. Also, it make things simple enough
to deal with overlapped modal.
It will use a local element, created by which will still be visible by
getting
node
property.Changes proposed:
div
provided by the instance of to setup things.<Modal />
can perform its own clean up.Upgrade Path (for changed or removed APIs):
getParentElement
.Acceptance Checklist:
CONTRIBUTING.md
.