Support any number of args on action creators.

Fixes #187
reactjs · Jan 31, 2016 · 524898b · 524898b
1 parent 0f85508
commit 524898b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 13 deletions.
diff --git a/src/index.js b/src/index.js
@@ -6,9 +6,9 @@ export const UPDATE_LOCATION = '@@router/UPDATE_LOCATION'
 const SELECT_LOCATION = state => state.routing.location
 
 function transition(method) {
-  return arg => ({
+  return (...args) => ({
     type: TRANSITION,
-    payload: { method, arg }
+    payload: { method, args }
   })
 }
 
@@ -65,8 +65,8 @@ export function syncHistory(history) {
         return next(action)
       }
 
-      const { payload: { method, arg } } = action
-      history[method](arg)
+      const { payload: { method, args } } = action
+      history[method](...args)
     }
   }
 

diff --git a/test/createTests.js b/test/createTests.js
@@ -58,18 +58,26 @@ module.exports = function createTests(createHistory, name, reset = defaultReset)
             type: TRANSITION,
             payload: {
               method: 'push',
-              arg: '/foo'
+              args: [ '/foo' ]
             }
           })
 
           expect(push({ pathname: '/foo', state: { the: 'state' } })).toEqual({
             type: TRANSITION,
             payload: {
               method: 'push',
-              arg: {
+              args: [ {
                 pathname: '/foo',
                 state: { the: 'state' }
-              }
+              } ]
+            }
+          })
+
+          expect(push('/foo', 'baz', 123)).toEqual({
+            type: TRANSITION,
+            payload: {
+              method: 'push',
+              args: [ '/foo' , 'baz', 123 ]
             }
           })
         })
@@ -81,18 +89,18 @@ module.exports = function createTests(createHistory, name, reset = defaultReset)
             type: TRANSITION,
             payload: {
               method: 'replace',
-              arg: '/foo'
+              args: [ '/foo' ]
             }
           })
 
           expect(replace({ pathname: '/foo', state: { the: 'state' } })).toEqual({
             type: TRANSITION,
             payload: {
               method: 'replace',
-              arg: {
+              args: [ {
                 pathname: '/foo',
                 state: { the: 'state' }
-              }
+              } ]
             }
           })
         })
@@ -104,7 +112,7 @@ module.exports = function createTests(createHistory, name, reset = defaultReset)
             type: TRANSITION,
             payload: {
               method: 'go',
-              arg: 1
+              args: [ 1 ]
             }
           })
         })
@@ -116,7 +124,7 @@ module.exports = function createTests(createHistory, name, reset = defaultReset)
             type: TRANSITION,
             payload: {
               method: 'goBack',
-              arg: undefined
+              args: []
             }
           })
         })
@@ -128,7 +136,7 @@ module.exports = function createTests(createHistory, name, reset = defaultReset)
             type: TRANSITION,
             payload: {
               method: 'goForward',
-              arg: undefined
+              args: []
             }
           })
         })