Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setInterval is not defined for execsjs #1335

Closed
justin808 opened this issue Jan 31, 2016 · 2 comments
Closed

setInterval is not defined for execsjs #1335

justin808 opened this issue Jan 31, 2016 · 2 comments

Comments

@justin808
Copy link

See comment here:

e2e14d2#diff-1fdf421c05c1140f6d71444ea2b27638

Copied here:

@gaearon This change of referencing setInterval broke server rendering for https://github.com/shakacode/react_on_rails/ as running this code through execjs fails because setInterval is not defined, per this [FAQ for execjs]( (https://github.com/sstephenson/execjs#faq).

I'll polyfill this for now, but I recommend that you change the line to:

setInterval && setInterval.name === 'setInterval'

References:

@justin808
Copy link
Author

I polyfilled this here: shakacode/react_on_rails@59f1e68

@gaearon
Copy link
Contributor

gaearon commented Jan 31, 2016

Fixed in 3.1.7, thanks for reporting.

DannyMay9082 added a commit to DannyMay9082/react_on_rails that referenced this issue Feb 16, 2023
Web-Go-To added a commit to Web-Go-To/react-with-rails that referenced this issue Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants