Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setInterval is not defined for execsjs #1335

Closed
justin808 opened this issue Jan 31, 2016 · 2 comments
Closed

setInterval is not defined for execsjs #1335

justin808 opened this issue Jan 31, 2016 · 2 comments

Comments

@justin808
Copy link

See comment here:

e2e14d2#diff-1fdf421c05c1140f6d71444ea2b27638

Copied here:

@gaearon This change of referencing setInterval broke server rendering for https://github.com/shakacode/react_on_rails/ as running this code through execjs fails because setInterval is not defined, per this [FAQ for execjs]( (https://github.com/sstephenson/execjs#faq).

I'll polyfill this for now, but I recommend that you change the line to:

setInterval && setInterval.name === 'setInterval'

References:
This was referenced Jan 31, 2016
Merged
Closed
justin808 added a commit to shakacode/react_on_rails that referenced this issue Jan 31, 2016
@justin808
Fixes server rendering with polyfill
59f1e68 
Caused by issue:
reduxjs/redux#1335
@justin808
Copy link
Author

I polyfilled this here: shakacode/react_on_rails@59f1e68

@gaearon
Copy link
Contributor

gaearon commented Jan 31, 2016

Fixed in 3.1.7, thanks for reporting.

fstar-dev added a commit to fstar-dev/react-on-rails that referenced this issue Jan 27, 2023
@fstar-dev
Fixes server rendering with polyfill
fcaf710 
Caused by issue:
reduxjs/redux#1335
DannyMay9082 added a commit to DannyMay9082/react_on_rails that referenced this issue Feb 16, 2023
@DannyMay9082
Fixes server rendering with polyfill
26e994f 
Caused by issue:
reduxjs/redux#1335
Web-Go-To added a commit to Web-Go-To/react-with-rails that referenced this issue Mar 19, 2023
@Web-Go-To
Fixes server rendering with polyfill
90e9d66 
Caused by issue:
reduxjs/redux#1335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @justin808