Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate "React Top-Level API" into Russian #66

Merged
merged 50 commits into from Feb 27, 2019
Merged

Translate "React Top-Level API" into Russian #66

merged 50 commits into from Feb 27, 2019

Conversation

ModPhoenix
Copy link
Contributor

Нужно обсудить как переводить Suspense и переводить ли вообще.

Так же не уверен что правильно перевел строку номер 189, поскольку не до конца понял оригинальную (my bad).

@gaearon
Copy link
Member

gaearon commented Feb 10, 2019

Про Suspense #70 (API переводить не надо, а вот концепцию наверное надо)

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошо, вот первый фидбэк

content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Надо поменять неглубокое на поверхностное еще. #71

@tesseralis tesseralis mentioned this pull request Feb 11, 2019
88 tasks
@ModPhoenix
Copy link
Contributor Author

@gaearon улучшил перевод согласно рекомендациям (прошу прощения за задержку).

Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предложения для улучшения перевода.

content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 17, 2019
lex111 and others added 18 commits February 18, 2019 12:39
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
@ModPhoenix
Copy link
Contributor Author

@lex111 Спасибо за помощь, я оставил несколько комментариев для уточнения.

Copy link
Collaborator

@ntishkevich ntishkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ёфикация была проведена. 😄

content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
content/docs/reference-react.md Outdated Show resolved Hide resolved
@another-guy
Copy link
Collaborator

@ModPhoenix будьте добры, пройдитесь по предложенным изменениям, чтобы PR был принят. 🤝

@another-guy another-guy added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 25, 2019
another-guy and others added 22 commits February 27, 2019 08:57
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
Co-Authored-By: ModPhoenix <ivanchenko.b@gmail.com>
@ModPhoenix
Copy link
Contributor Author

Большое спасибо @gaearon @lex111 @another-guy @ntishkevich за помощь и улучшение перевода!

@another-guy another-guy merged commit 0771693 into reactjs:master Feb 27, 2019
@another-guy
Copy link
Collaborator

@ModPhoenix, спасибо за терпение и хорошую работу !!! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress Author opened the pull-request but it's still being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants