Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftLint config error on carthage build #45

Closed
toshi0383 opened this issue Mar 4, 2016 · 2 comments
Closed

SwiftLint config error on carthage build #45

toshi0383 opened this issue Mar 4, 2016 · 2 comments

Comments

@toshi0383
Copy link

On carthage build or carthage update , this library currently emits swiftlint config errors.

$ carthage build --platform tvos SwiftState
*** xcodebuild output can be found in /var/folders/tr/3lftss053tqdh731cgt0w1p00000gn/T/carthage-xcodebuild.eJzwNs.log
*** Building scheme "SwiftState" in SwiftState.xcodeproj
2016-03-05 01:41:43.498 xcodebuild[19404:463121] ### Failed to load Addressbook class CNContactNameFormatter
2016-03-05 01:41:48.926 xcodebuild[19466:463272] ### Failed to load Addressbook class CNContactNameFormatter
configuration error: 'variable_name_min_length' is not a valid rule identifier
configuration error: 'variable_name_min_length' is not a valid rule identifier

IMO, a library should not be running SwiftLint in its Build Phase.

@inamiy
Copy link
Member

inamiy commented Mar 8, 2016

Thanks for issue! I fixed it in #46.

@inamiy inamiy closed this as completed Mar 8, 2016
@toshi0383
Copy link
Author

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants