Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2124 Backport and improve discard handling in UnicastProcessor #2126

Merged
merged 2 commits into from Apr 22, 2020
Merged

fix #2124 Backport and improve discard handling in UnicastProcessor #2126

merged 2 commits into from Apr 22, 2020

Commits on Apr 22, 2020

  1. Backport #2102 Provide onDiscard support in UnicastProcessor 

    Reviewed-in: #2126
    @simonbasle
    simonbasle committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    3d3e3b9 View commit details
    Browse the repository at this point in the history

  2. fix #2124 UnicastProcessor discards when onNext/cancel races 

    This is a follow-up to #2125, this time targeting the same class of
discarding race but on `UnicastProcessor`.

As there is a chance that the race references `actual` (to resolve the
discard hook) AFTER `cancel()`, we need to keep that field populated.
It was nulled out for the benefit of `downstreamCount()` (see #980) so
we replace that by a boolean, set to true when subscribed.

Reviewed-in: #2126
    @simonbasle
    simonbasle committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    9a76624 View commit details
    Browse the repository at this point in the history