Remove @Sharable and replace it with default method
#12522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperxpro
reviewed
Jun 28, 2022
normanmaurer
commented
Jun 28, 2022
chrisvest
approved these changes
Jun 28, 2022
trustin
approved these changes
Jun 29, 2022
Motivation: Now that we depend on java8+ we should just use a default method that can be override to declare a handler sharable. This makes things a bit cheaper and also allow to fail to restrict sharable when compiling by let implementations declare the method final. Modifications: - Remove annotation and add default method to ChannelHandler interface - Adjust implementations Result: Better way to declare a handler sharable or not
Co-authored-by: Trustin Lee <t@motd.kr>
normanmaurer
force-pushed
the
sharable_annotation
branch
from
9d596e8
to
b2e99d8
Compare
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Jun 29, 2022
- `@Sharable` is removed netty/netty#12522 - `ByteToMessageDecoderForBuffer` is renamed to `ByteToMessageDecoder` netty/netty#12512 - `ByteBuf` adapters are moved to Netty Contrib netty/netty#12512 - Enable `ObservabilitySmokeTest` netty/netty#12518 - `ByteBufAllocatorMetrics` functionality needs migration #2341 - Adapt CI build Related to #1873
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Jun 29, 2022
- `@Sharable` is removed netty/netty#12522 - `ByteToMessageDecoderForBuffer` is renamed to `ByteToMessageDecoder` netty/netty#12512 - `ByteBuf` adapters are moved to Netty Contrib netty/netty#12512 - Enable `ObservabilitySmokeTest` netty/netty#12518 - `ByteBufAllocatorMetrics` functionality needs migration #2341 - Adapt CI build Related to #1873
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Now that we depend on java8+ we should just use a default method that can be override to declare a handler sharable. This makes things a bit cheaper and also allow to fail to restrict sharable when compiling by let implementations declare the method final.
Modifications:
Result:
Better way to declare a handler sharable or not