Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First class support for PHP7 and HHVM #54

Merged
merged 1 commit into from
Feb 23, 2016

Conversation

clue
Copy link
Contributor

@clue clue commented Nov 22, 2015

Closes #27

@clue
Copy link
Contributor Author

clue commented Nov 22, 2015

The failing tests are due to error reporting which is fixed in #47. This likely needs rebasing once that one is in.

@flip111
Copy link

flip111 commented Nov 30, 2015

#27 isn't actually closed yet

@clue
Copy link
Contributor Author

clue commented Feb 23, 2016

The failing tests are due to error reporting which is fixed in #47. This likely needs rebasing once that one is in.

Restarted the Travis build now that #47 is in, all green 👏

#27 isn't actually closed yet

HHVM 3.8 (released several months ago) introduced the required stream_socket_enable_crypto() function. This means that newer versions work correctly, whereas older versions now return a rejected Promise instead of crashing.

@clue clue modified the milestone: v0.5 Feb 23, 2016
cboden added a commit that referenced this pull request Feb 23, 2016
First class support for PHP7 and HHVM
@cboden cboden merged commit 1cc368e into reactphp-legacy:master Feb 23, 2016
@clue clue deleted the php branch August 1, 2016 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants