Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for SSL/TLS sockets #62

Merged
merged 10 commits into from
Mar 14, 2016

Conversation

clue
Copy link
Contributor

@clue clue commented Mar 9, 2016

This PR adds a few additional integration tests for SSL/TLS sockets in the hope of addressing all related buffering issues (#14, #24, #26, #57 and possibly more).

This is essentially an updated version of #16.

@clue
Copy link
Contributor Author

clue commented Mar 12, 2016

The tests are failing… *sigh* We've changed to Travis' container-based infrastructure with #54, which means executing sudo is longer allowed and installing arbitrary packages is severely limited. We need to install openssl and any (arbitrary) TLS/SSL terminating proxy.

Neither of stunnel, haproxy, stud or hitch are on the package whitelist though: https://github.com/travis-ci/apt-package-whitelist (see also travis-ci/apt-package-safelist#403)

We may look into building a TLS/SSL proxy from source, but I'd rather not go down that road.

As an alternative, I've started looking into implementing TLS/SSL socket support in React (reactphp/socket#24), which happens to works surprisingly well. However, this will likely need a few smaller patches in different React components, so expect this to take a while before this lands.

Perhaps anybody else happens to know a simple TLS/SSL proxy that is easy to set up in Travis? 👍

@clue clue force-pushed the tests branch 4 times, most recently from 057cac7 to 80a7d04 Compare March 12, 2016 12:21
@clue
Copy link
Contributor Author

clue commented Mar 12, 2016

We may look into building a TLS/SSL proxy from source, but I'd rather not go down that road.

Let's face it, this is probably still easier than updating our components. The PR has been updated, so let's get this in :shipit: 🎉

Test receiving larger buffers without ending the stream
@cboden cboden merged commit f15683a into reactphp-legacy:master Mar 14, 2016
@cboden
Copy link
Contributor

cboden commented Mar 14, 2016

Great job! Please add a milestone to this before tagging.

@clue clue deleted the tests branch August 4, 2016 19:34
@clue clue added this to the v0.5.0 milestone Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants