-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for SSL/TLS sockets #62
Conversation
This allows us to test with self-signed certificates across all PHP versions
The tests are failing… *sigh* We've changed to Travis' container-based infrastructure with #54, which means executing Neither of We may look into building a TLS/SSL proxy from source, but I'd rather not go down that road. As an alternative, I've started looking into implementing TLS/SSL socket support in React (reactphp/socket#24), which happens to works surprisingly well. However, this will likely need a few smaller patches in different React components, so expect this to take a while before this lands. Perhaps anybody else happens to know a simple TLS/SSL proxy that is easy to set up in Travis? 👍 |
057cac7
to
80a7d04
Compare
Let's face it, this is probably still easier than updating our components. The PR has been updated, so let's get this in 🎉 |
Test receiving larger buffers without ending the stream
Great job! Please add a milestone to this before tagging. |
This PR adds a few additional integration tests for SSL/TLS sockets in the hope of addressing all related buffering issues (#14, #24, #26, #57 and possibly more).
This is essentially an updated version of #16.