Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing OPT records (EDNS0) #157

Merged
merged 2 commits into from Mar 27, 2020
Merged

Support parsing OPT records (EDNS0) #157

merged 2 commits into from Mar 27, 2020

Conversation

clue
Copy link
Member

@clue clue commented Mar 22, 2020

This PR adds support for parsing and serializing OPT record types in accordance to RFC 6891. Among others, this is a prerequisite for parsing EDNS0 responses (#100) and also DNSSEC, DNS-over-TLS (DoT #80) and DNS-over-HTTPS (DoH) which is left up to a follow-up PR. This is a pure feature addition (without any BC breaks), though this is not currently used in practice.

Builds on top of #123 and #124
Refs #100

@clue clue added this to the v1.3.0 milestone Mar 22, 2020
@clue clue requested review from jsor and WyriHaximus March 22, 2020 20:03
Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsor jsor merged commit a6ff7b9 into reactphp:master Mar 27, 2020
@clue clue deleted the opt branch June 15, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants