Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check PCNTL functions for signal support instead of PCNTL extension #195

Merged
merged 1 commit into from May 8, 2019

Conversation

clue
Copy link
Member

@clue clue commented May 7, 2019

This helps avoiding problems when the PCNTL extension is loaded, but
(some of) its functions are disabled via PHPs disable_function
configuration. This is particularly common for the PCNTL functions in
CGI environments, e.g. they are disabled by default on Debian- /
Ubuntu-based distributions. Previously, even when not attaching any
signal listeners, the loop would print a warning on each loop tick:

PHP Warning: pcntl_signal_dispatch() has been disabled for security
reasons in {file} on {line}

Builds on top of #179

This helps avoiding problems when the PCNTL extension is loaded, but
(some of) its functions are disabled via PHPs `disable_function`
configuration. This is particularly common for the PCNTL functions in
CGI environments, e.g. they are disabled by default on Debian- /
Ubuntu-based distributions. Previously, even when not attaching any
signal listeners, the loop would print a warning on each loop tick:

> PHP Warning:  pcntl_signal_dispatch() has been disabled for security
reasons in {file} on {line}
@clue clue added the bug label May 7, 2019
@clue clue added this to the v1.1.1 milestone May 7, 2019
@WyriHaximus WyriHaximus requested review from WyriHaximus and jsor May 7, 2019
jsor
jsor approved these changes May 7, 2019
@WyriHaximus WyriHaximus merged commit 060092e into reactphp:master May 8, 2019
1 check was pending
@clue clue deleted the pcntl-might-be-disabled branch May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants