Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pcntl async signal dispatching if available #179

Merged
merged 1 commit into from Jan 19, 2019
Merged

Add pcntl async signal dispatching if available #179

merged 1 commit into from Jan 19, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 14, 2019

This PR makes it possible to use PCNTL's asynchronous signal dispatching, if PHP 7.1 or higher is used. This allows to dispatch signals anywhere, without any overhead. This also means signals can be handled faster and more efficient, without having to rely on the manual dispatch on each tick.

RFC for async signals dispatching: https://wiki.php.net/rfc/async_signals

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@clue clue merged commit c795e50 into reactphp:master Jan 19, 2019
@ghost ghost deleted the async-dispatch branch January 19, 2019 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants