Replace the abandoned guzzle/parser #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
👍 |
| @@ -3,7 +3,7 @@ | |||
| namespace React\HttpClient; | |||
|
|
|||
| use Evenement\EventEmitterTrait; | |||
| use Guzzle\Parser\Message\MessageParser; | |||
| use GuzzleHttp\Psr7 as g7; | |||
There was a problem hiding this comment.
I'm sorry to nitpick but can we come up with another alias? I used gPsr other places. At the rate Guzzle releases major versions this could quickly get mixed up with misunderstanding "Guzzle7".
|
I took my own advice :) reactphp/http#37 |
|
@cboden cheers I took your advise and will merge it 👍 |
| $parser = new MessageParser(); | ||
| $parsed = $parser->parseResponse($data); | ||
| $psrResponse = gPsr\parse_response($data); | ||
| $headers = array_map(function(&$val) { |
There was a problem hiding this comment.
& should be removed. My fault on copy/paste fail
|
👍 |
|
If no one objects to this by tomorrow morning I'm merging it and tagging 0.4.5. |
|
LGTM |
cboden
added a commit
that referenced
this pull request
Aug 30, 2015
Replace the abandoned guzzle/parser
|
Or you just merge it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23
overrules #26
This replaces the old abandoned guzzle/parser with guzzlehttp/psr7