Naming, immutable array manipulation #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
WyriHaximus
added a commit
that referenced
this pull request
Aug 24, 2015
Naming, immutable array manipulation
|
👍 thanks! |
| @@ -99,12 +99,13 @@ public function parseHeaders($data) | |||
| parse_str($queryString, $parsedQuery); | |||
| } | |||
|
|
|||
| $headers = $psrRequest->getHeaders(); | |||
| array_walk($headers, function(&$val) { | |||
| $headers = array_map(function(&$val) { | |||
There was a problem hiding this comment.
$val doesn't still need to be passed by reference here, does it?
|
Ooops. I copy/paste fail. |
|
Do you want to PR and fix it or want me to? |
|
I'd say just go ahead and push the fix :) |
|
Done 👍 |
clue
added a commit
to clue-labs/http
that referenced
this pull request
Aug 9, 2016
This effectively reverts to 8602944, thus reverting reactphp#13, reactphp#37, reactphp#45 and reactphp#47
clue
pushed a commit
to clue-labs/http
that referenced
this pull request
Aug 9, 2016
This is a sqashed version to add back the changes from reactphp#37: - 2ab98d2 - 75ff84a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.