adapt for amphp promises

[ghost]

same as in https://github.com/amphp/amp/blob/master/lib/functions.php#L226 for \Amp\Promise

[cboden]

I think this type of support would be better in its own repo. I don't like the idea of introducing an API that relies on a library that may or may not be available.

[ghost]

https://github.com/umbri/amp-react-interop

[ghost]

Just in case: I am using namespace React\Promise
https://github.com/umbri/amp-react-interop/blob/master/lib/functions.php#L33

Should I change that ?

[cboden]

Yes please. React is this organizations namespace.

[ghost]

Ok, no problem I will change that

[kelunik]

@cboden While a separate package could also make sense, I think including something like that into another package like this one directly can make sense for improved discoverability.

The type declaration could also be dropped in the future to allow for other promise implementations to be easily adapted, too.

[kelunik]

@umbri I think it would make sense to simply support it in here instead of a separate adapt method.

[jsor]

I think it makes perfect sense to provide that via a separate package. If Amp wants to be consumable by promise libs, it can provide a then() method. This would make it consumable by ReactPHP's promises and also Guzzle's promises.

[clue]

Thanks for the PR @umbri, I think this sparked a very good discussion and lead the right thing: Your adapter is much appreciated and I suppose something that people that are interested in using amphp with ReactPHP would be interested in 👍

Other than that, I agree with @cboden and @jsor in that it doesn't make much sense to provide adapters for all kinds of (niche) third party projects here, in particular given that we already support "foreign promises" (anything with a standard then() method).

@kelunik As much as I understand your effort, I don't think this project should be concerned with "improved discoverability" of (niche) third party projects that this project has no involvement whatsoever with.

I believe this has been answered, so I'm closing this for now. Please come back with more details if this persists and we can reopen this 👍

Again, thanks for the discussion everybody and thanks @umbri for bringing this idea to the table 👍