Set Modal.openCount floor to 0 #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug where Modal.openCount becomes negative after multiple .destroy() calls
TheSharpieOne
approved these changes
Jan 18, 2019
juanmaguitar
added a commit
to juanmaguitar/reactstrap
that referenced
this pull request
Jan 18, 2019
* 'master' of github.com:reactstrap/reactstrap: (81 commits) fix(Modal): set Modal.openCount floor to 0 (reactstrap#1368) feat(Popover): add default toggleable fade support (reactstrap#1364) (reactstrap#1364) chore(release): release 7.1.0 feat(Popover): add legacy trigger, replacing isInteractive prop feat(Popover): backward-compatible Popover behavior (reactstrap#1360) Fix(Modal): don't treat clicks on Portal children as backdrop clicks (reactstrap#1359) feat(*): support forwardRef components as tag fix(NavLink): console error while using @reach/Router (reactstrap#1350) feat(Spinner): Add spinner component (reactstrap#1352) feat(Switch): Add support for CustomInput type='switch' (reactstrap#1353) chore(release): adding 7.0.2 fix(npm): fix published files chore(release): adding 7.0.1 fix(*): fix release artifacts (reactstrap#1345) chore(release): adding 7.0.0 (reactstrap#1342) docs(typo): Fix misspelling in documentation (Alerts) (reactstrap#1329) docs(Input): static input error (reactstrap#1335) fix lint issue Bug/v7 merge conflict fix (reactstrap#1324) feat(CardBody): add innerRef to CardBody (reactstrap#1318) ...
|
It doesn't actually fix it I think. You might have a few opened modal windows, so a few calls of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug described in #1279 where Modal.openCount becomes negative after multiple .destroy() calls, preventing "modal-open" from being added to document.body.
Solution is prevent Modal.openCount from going below a minimum of 0, rejecting decrements that result in an erroneous negative value.