feat(Progress): Allow passing in custom style object #1771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for more flexibility in styling
Ran into a scenario where I could use passing in styles in this manner.
My use case involves mapping over a collection and creating slightly rounded progress bars which overlap (to cover the space created at the corners by border-radius), and I could use the ability of passing in
zIndex
values programmatically.I realize this makes
Progress
"special", seeing as none of the other components accept the style prop. If you want me to do this for all components, let me know.EDIT:
DropdownMenu › should not render multiple children when isOpen is false
fails, but it shouldn't be because of this PR.