Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract the toolkit over publication source #353

Merged
merged 37 commits into from
Jul 17, 2023
Merged

Conversation

qnga
Copy link
Contributor

@qnga qnga commented May 25, 2023

This is a major refactoring of MediaType and Streamer, introducing the new Resource and Asset types along with AssetRetriever, MediaTypeRetriever and ContentProtectionSchemeRetriever.

To be done in another PR:

  • make error handling more consistent
  • partially cache and buffer data for single file publications
  • relax conditions for reading LCP-protected publications from shared storage
  • user guide for the components replacing Streamer

@qnga qnga changed the title Refactor streamer Abstract the toolkit over publication source Jul 10, 2023
@qnga qnga requested a review from mickael-menu July 10, 2023 07:02
@qnga qnga marked this pull request as ready for review July 10, 2023 07:02
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes, it's coming along nicely 👍

@mickael-menu mickael-menu merged commit 6a489f7 into v3 Jul 17, 2023
3 checks passed
@mickael-menu mickael-menu deleted the refactor-streamer branch July 17, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants