Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Letter-spacing for japanese #136

Open
JayPanoz opened this issue Apr 19, 2024 · 9 comments
Open

Letter-spacing for japanese #136

JayPanoz opened this issue Apr 19, 2024 · 9 comments
Labels
2024 Update New discussions, issues and requests triggered by the 2024 update Discussion feedback required Proposed solution Issues or feature requests with a solution in reach

Comments

@JayPanoz
Copy link
Collaborator

JayPanoz commented Apr 19, 2024

I'm submitting a topic for discussion.

Short description of the issue/suggestion:

letter-spacing has been enabled as a user setting for Japanese in Thorium and I’m wondering if we should enable it globally in ReadiumCSS.

At the time we first checked it was unclear whether it would help A11y-wise for CJK but feedback has been collected since and maybe we could improve on this front.

@JayPanoz JayPanoz added feedback required Discussion 2024 Update New discussions, issues and requests triggered by the 2024 update labels Apr 19, 2024
@HadrienGardeur
Copy link

Letter spacing has also been implemented in the Preferences API for Readium Mobile.

@JayPanoz
Copy link
Collaborator Author

Thanks for the quick feedback, I guess this pretty much answers this question then. 🙏

@danielweck
Copy link
Member

just to be clear, Thorium has always offered letter-spacing but the issue was that ReadiumCSS was explicitly excluding Japanese, so we forced this.

@danielweck
Copy link
Member

also, word-spacing for Japanese with wbr elements required CSS and JavaScript tricks to get working. it is a non-standard technique but it works for Thorium JA users.

@mickael-menu
Copy link
Member

We have letter-spacing in the mobile toolkits but it's only marked as "effective" with the default stylesheet – so no CJK or RTL. We followed the instructions from Readium CSS's doc.

Let me know if it needs to be updated.

@JayPanoz
Copy link
Collaborator Author

@mickael-menu not at the moment but there is a use-case for JA users, as demonstrated in Thorium. At the time we researched a11y, resources were lacking for CJK and RTL. It’s probably worth researching this topic again and see if we can enable the setting for more languages.

My to-do list then:

  • research letter-spacing and word-spacing for CJK and RTL – although word-spacing might be really challenging in CSS-only, as reported by Daniel
  • modify the user-setting submodules if needed
  • import the user-setting submodules in the “bundleable stylesheets”
  • update documentation

@mickael-menu
Copy link
Member

If you need, I think you could reach out to these users for more insights with CJK:

In particular, it looks like the paginated mode doesn't work as they expected.

@JayPanoz
Copy link
Collaborator Author

Some interesting issues from WCAG – looks like we’re not the only ones struggling on this topic:

@JayPanoz
Copy link
Collaborator Author

Proposed resolution: I guess it will make more sense enabling it for all CJK, and letting implementers enable/disable the setting as they see fit – and make it clear in documentation.

@JayPanoz JayPanoz added the Proposed solution Issues or feature requests with a solution in reach label May 16, 2024
JayPanoz added a commit that referenced this issue May 22, 2024
@JayPanoz JayPanoz mentioned this issue May 23, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024 Update New discussions, issues and requests triggered by the 2024 update Discussion feedback required Proposed solution Issues or feature requests with a solution in reach
Projects
None yet
Development

No branches or pull requests

4 participants