-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of body overflow #138
Comments
OK so I explored As a disclaimer, we’re already finding ourselves dealing with progressive enhancement and the lack of guideline/policy (issue #139) given it’s part of the 2022 baseline, with support available from Chrome 90, Firefox 80, and Safari 16. As a spoiler, this would be an incomplete fix due to partial support of MDN docsSupportSummary
My guess is RecapIn theory, this could help solve this issue. At least in isolation in ReadiumCSS, it is working as expected as a fix – of course it’s another story in apps injecting ReadiumCSS. Anyways, adding the following deals with all the overflow issues:
You need both As a reference, no Without With I’ve checked and IssuesUpdate: Turns out the support tables you can find on popular websites were wrong… As far as ReadiumCSS is concerned, mainly support, which means this would fix overflow issues for the latest versions of browsers/webviews, but only partially due to the support of
As far as apps are concerned, this is unknown. ConclusionThis |
Does the below code resolve the issue? overflow-wrap: break-word; |
@fondoger Thanks for weighing in and pointing that out. From initial testing it created some issues and didn’t necessarily offer the best expected results, especially in hyphenated contexts. However, it’s something that might be revisited in the future, with the implementation of version 2 in toolkits. We will have to pay a particular attention to the overflow issue for practical reasons so I’m expecting additional effort being spent in the upcoming weeks. |
I'm submitting a need for improvement
We have several issues related to
overflow
inbody
(CSS multicolumn) so there is clearly a need to improve ReadiumCSS here.List of know issues:
overflow-x: hidden
style breaks pagination #119At least text shouldn’t be visibly overflowing in the next column, but if we can also guarantee it will break in order to stay readable, this will be a better solution, obviously.
The text was updated successfully, but these errors were encountered: