Skip to content

Commit

Permalink
return type bug (launcher iOS compiler was complaining...not sure why…
Browse files Browse the repository at this point in the history
… this hasn't surfaced before??)
  • Loading branch information
danielweck committed Mar 13, 2014
1 parent 0101850 commit b3fb4ae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ePub3/ePub/property_holder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ PropertyPtr PropertyHolder::PropertyMatching(const string& reference, const stri
{
IRI iri = MakePropertyIRI(reference, prefix);
if ( iri.IsEmpty() )
return false;
return nullptr;
return PropertyMatching(iri, lookupParents);
}

Expand Down

3 comments on commit b3fb4ae

@eikemeier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is actually pull request #36 which addresses this issue.

@danielweck
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eikemeier Indeed, it's about time this simple fix makes its way into the develop branch! :)
...as for the rest of pull request #36, I am not really in a position to comment, so I will let the developer who owns this part decide what to do (it looks like a trivial merge to me though).

@bluefirepatrick
Copy link
Member

@bluefirepatrick bluefirepatrick commented on b3fb4ae Mar 17, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.