Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: glossary niceness and more #879

Merged
merged 7 commits into from
May 22, 2024
Merged

feat: glossary niceness and more #879

merged 7 commits into from
May 22, 2024

Conversation

kellyjosephprice
Copy link
Collaborator

@kellyjosephprice kellyjosephprice commented May 20, 2024 •
edited

PR App Fix RM-9669, RM-9767

🧰 Changes

Refactors glossary stuff.

  1. <GlossaryItem /> -> <Glossary />
    I kept typing the wrong thing, so...

  2. <Glossary term="parliament" /> -> <Glossary>parliament</Glossary>
    Because greg said so.

  3. Moves the Glossary, Variables, and BaseUrl contexts into this repo. The values are now passed in as options. This should make mdx-renderer simpler.

🧬 QA & Testing

@kellyjosephprice kellyjosephprice changed the base branch from next to beta May 20, 2024 22:29
@kellyjosephprice kellyjosephprice marked this pull request as ready for review May 20, 2024 22:35
jennspencer
jennspencer approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@jennspencer jennspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe change <Variable variable="thing" /> to like var="thing" because i've now read 'variable' too many times and it's no longer a real word to me

@kellyjosephprice
Copy link
Collaborator Author

LGTM but maybe change <Variable variable="thing" /> to like var="thing" because i've now read 'variable' too many times and it's no longer a real word to me

Should it be similar to Glossary:

<Variable>thing</Variable>

@jennspencer
Copy link
Contributor

LGTM but maybe change <Variable variable="thing" /> to like var="thing" because i've now read 'variable' too many times and it's no longer a real word to me

Should it be similar to Glossary:

<Variable>thing</Variable>

that works for a glossary item because you're actually displaying the word, but it feels weird for a variable?

@kellyjosephprice kellyjosephprice merged commit 43b5256 into beta May 22, 2024
10 of 11 checks passed
@kellyjosephprice kellyjosephprice deleted the feat/glossary-niceness branch May 22, 2024 22:43
rafegoldberg pushed a commit that referenced this pull request May 22, 2024
@semantic-release-bot
build(release): 🚀 v6.75.0-beta.36 🦉
3455148 
## Version 6.75.0-beta.36

### ✨ New & Improved

* glossary niceness and more ([#879](#879)) ([43b5256](43b5256))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor

This PR was released!

🚀 Changes included in v6.75.0-beta.36

@kellyjosephprice kellyjosephprice mentioned this pull request Jul 9, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennspencer jennspencer jennspencer approved these changes

@Dashron Dashron Awaiting requested review from Dashron

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kellyjosephprice @jennspencer @rafegoldberg