-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: glossary niceness and more #879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but maybe change <Variable variable="thing" />
to like var="thing"
because i've now read 'variable' too many times and it's no longer a real word to me
Should it be similar to Glossary:
|
that works for a glossary item because you're actually displaying the word, but it feels weird for a variable? |
This PR was released!🚀 Changes included in v6.75.0-beta.36 |
🧰 Changes
Refactors glossary stuff.
<GlossaryItem />
-><Glossary />
I kept typing the wrong thing, so...
<Glossary term="parliament" />
-><Glossary>parliament</Glossary>
Because greg said so.
Moves the Glossary, Variables, and BaseUrl contexts into this repo. The values are now passed in as options. This should make
mdx-renderer
simpler.🧬 QA & Testing