feat(eslint-config): dropping use of eslint-plugin-prettier
#832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
requested changes
Apr 2, 2024
kanadgupta
reviewed
Apr 2, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kanadgupta
approved these changes
Apr 2, 2024
Co-authored-by: Kanad Gupta <8854718+kanadgupta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
We're dropping use of
eslint-plugin-prettierwithin our main ESLint config as we've been experiencing some performance setbacks with it in our large codebase. Instead we now recommend running Prettier separately alongside ESLint (whichtypescript-eslintalso recommends doing1).Footnotes
https://typescript-eslint.io/troubleshooting/performance-troubleshooting/#eslint-plugin-prettier ↩