Merge pull request #5421 from stsewd/always-update-stable

Always update the commit of the stable version

readthedocs/projects/models.py

@@ -919,7 +919,7 @@ def update_stable_version(self):
                 identifier_updated = (
                     new_stable.identifier != current_stable.identifier
                 )
-                if identifier_updated and current_stable.active and current_stable.machine:
+                if identifier_updated and current_stable.machine:
                     log.info(
                         'Update stable version: {project}:{version}'.format(
                             project=self.slug,

readthedocs/restapi/views/model_views.py

@@ -216,8 +216,8 @@ def sync_versions(self, request, **kwargs):  # noqa: D205
             )
 
         promoted_version = project.update_stable_version()
-        if promoted_version:
-            new_stable = project.get_stable_version()
+        new_stable = project.get_stable_version()
+        if promoted_version and new_stable and new_stable.active:
             log.info(
                 'Triggering new stable build: {project}:{version}'.format(
                     project=project.slug,

readthedocs/rtd_tests/tests/test_sync_versions.py

@@ -967,9 +967,11 @@ def test_update_inactive_stable_version(self):
             content_type='application/json',
         )
 
+        # The identifier of stable is updated
+        # but the version is still not active
         version_stable = Version.objects.get(slug=STABLE)
         self.assertFalse(version_stable.active)
-        self.assertEqual(version_stable.identifier, '0.9')
+        self.assertEqual(version_stable.identifier, '1.0.0')
 
     def test_stable_version_tags_over_branches(self):
         version_post_data = {