Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projects built with htmldir have invalid link for homepage in search results #6102

Closed
dojutsu-user opened this issue Aug 26, 2019 · 0 comments · Fixed by #7070
Closed

Projects built with htmldir have invalid link for homepage in search results #6102

dojutsu-user opened this issue Aug 26, 2019 · 0 comments · Fixed by #7070
Labels
Bug A bug Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@dojutsu-user
Copy link
Member

Projects that are built with htmldir have invalid link in search results to homepage.
For example: https://2.python-requests.org/en/master/search/?q=%22The+Contributor%22

This is related to #5821.

We are using processed_json.path for the search results, but the correct path is present in full_path.

readthedocs.org/readthedocs/search/documents.py

Lines 73 to 74 in 3c04a96

path = fields.KeywordField(attr='processed_json.path')
full_path = fields.KeywordField(attr='path')

@dojutsu-user dojutsu-user added Bug A bug Improvement Minor improvement to code Needed: design decision A core team decision is required labels Aug 26, 2019
@stsewd stsewd mentioned this issue Jan 14, 2020
Merged
stsewd added a commit that referenced this issue May 12, 2020
@stsewd
Search: generate full link from the server side
4c48775 
We were returning an invalid link from the api,
and the cliente was in charge of guessing the correct link.

This also drops our builder as dependency for search 🎉

Half fixex/ #5821
Fixes #6102
@stsewd stsewd mentioned this issue May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search: generate full link from the server side readthedocs/readthedocs.org
1 participant
@dojutsu-user