Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't highlight version as outdated if it is the same as custom default branch #635

Closed
kmike opened this issue Jan 20, 2014 · 3 comments
Closed
Labels
Bug A bug

Comments

@kmike
Copy link

kmike commented Jan 20, 2014

In Scrapy default branch is set to 0.22: http://doc.scrapy.org/en/latest/

There is also an explicit 0.22 version from the same branch: http://doc.scrapy.org/en/0.22/ - it is highlighted as outdated.

I can just remove 0.22 from visible versions, but I think it is good to have URLs with explicit version number - links can become outdated otherwise.

@dangra
Copy link
Contributor

dangra commented Feb 5, 2014

Looks like it is outdated and it is not possible to trigger a build, trying to force a build on 0.22 updates "latest" branch instead, leaving docs at http://doc.scrapy.org/en/0.22/ outdated.

this urls should serve the same content but they doesn't:

@ericholscher
Copy link
Member

I believe this should be fixed with our updates to this logic -- please let me know if it is still an issue, and I will re-open.

@dangra
Copy link
Contributor

dangra commented Aug 20, 2015

looks good. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

4 participants