PRs show incorrect current version

[Daltz333]

Our PRs constantly link to another PR as the latest version, which isn't current.

https://frc-docs--905.org.readthedocs.build/en/905/

[stsewd]

This was already fixed in #7340. The problem here is that the API call isn't redirecting correctly for some reason

https://frc-docs--905.org.readthedocs.build/_/api/v2/footer_html/?_=1604327369858&absolute_uri=https%3A%2F%2Ffrc-docs--905.org.readthedocs.build%2Fen%2F905%2F&callback=jQuery351021399906449841266_1604327369857&docroot=%2Fsource%2F&format=jsonp&page=index&project=frc-docs&source_suffix=.rst&theme=sphinx_rtd_theme&version=905

(infinite redirect)

[stsewd]

Maybe do you have some redirects setup in your project? I can't replicate this in other projects

[stsewd]

This is weird, this only happening on this subdomain https://frc-docs--905.org.readthedocs.build/, https://frc-docs--915.org.readthedocs.build/en/915/ works fine

[stsewd]

Seeing an infinite redirect on the footer when the version is 905 https://frc-docs--905.org.readthedocs.build/_/api/v2/footer_html/?project=frc-docs&version=905&page=index&format=jsonp&docroot=%2Fsource%2F

It works with 906 https://frc-docs--905.org.readthedocs.build/_/api/v2/footer_html/?project=frc-docs&version=906&page=index&format=jsonp&docroot=%2Fsource%2F

Same for other subdomain https://frc-docs--915.org.readthedocs.build/_/api/v2/footer_html/?project=frc-docs&version=905&page=index&format=jsonp&docroot=%2Fsource%2F

[stsewd]

Found the problem, this happens when a version doesn't exist. We delete the version after the PR is closed, so the docs you are seeing are cached, or we don't delete them from storage.

This only happens on external versions

[Daltz333]

We do custom redirects using the sphinxext-rediraffe plugin. But I do not think that is the issue.

[stsewd]

We don't delete external versions when the PR is closed/merged now. We mark them as inactive, so the infinite redirect shouldn't happen now (in new builds).

[Daltz333]

This issue is still there. The redirect is fine but the detected latest version is false. It should use whatever is marked stable. Not another PR

[stsewd]

@Daltz333 is that a recent PR build? Can you put the link here?

[Daltz333]

Here is a PR that was updated recently https://frc-docs--974.org.readthedocs.build/en/974/

[stsewd]

I can see the api is returning show_version_warning: false. Looks like that message comes from this extension https://sphinx-version-warning.readthedocs.io/en/latest/configuration.html#confval-versionwarning_default_message, not from rtd.

[Daltz333]

Oh, lol.