Dependencies: all packages updated via pip-tools #10669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
humitos
reviewed
Aug 28, 2023
| @@ -234,7 +234,7 @@ markdown==3.4.4 | |||
| # via -r requirements/pip.txt | |||
| matplotlib-inline==0.1.6 | |||
| # via ipython | |||
| newrelic==8.10.1 | |||
| newrelic==8.11.0 | |||
There was a problem hiding this comment.
It seems there is a first party support for structlog now: https://docs.newrelic.com/docs/release-notes/agent-release-notes/python-release-notes/python-agent-81100/
We should take a closer look at NR logs after deploy.
There was a problem hiding this comment.
We should look into migrating our custom integration with struclog then
There was a problem hiding this comment.
Yes. I read the release notes and also the documentation but I didn't find a HowTo guide or similar. I was thinking that maybe it's "automatic" 🤔 -- If you find any documentation, please let me know or open an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies: all packages updated via pip-tools