Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: bugfix to show build notifications #11153

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 26, 2024

The context was updated in the wrong place.

Notifications are back:

Screenshot_2024-02-26_12-23-16

Closes #11146
Closes #11143

The context was updated in the wrong place.

Closes #11146
@humitos humitos requested a review from a team as a code owner February 26, 2024 11:22
@humitos humitos requested a review from stsewd February 26, 2024 11:22
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth a test.

@humitos humitos merged commit ac518c7 into main Feb 27, 2024
7 checks passed
@humitos humitos deleted the humitos/build-notifications branch February 27, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications: always show notifications on build details' page build fails silently when conf.py is missing
2 participants