Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extend Translation and Subproject form logic from corporate #3937

merged 2 commits into from Apr 12, 2018


Copy link

@humitos humitos commented Apr 11, 2018

There is no changes in the logic, just make these two forms extendable from Corporate site since we need to change some logic regarding the Organizations permissions.

Copy link

@agjohnson agjohnson left a comment

The old style settings was to create a new setting for every override. The new pattern is to user the override classes mapping instead.

@@ -281,6 +282,11 @@ def get_subproject_queryset(self):
return queryset

class ProjectRelationshipForm(SettingsOverrideObject):
_default_class = ProjectRelationshipBaseForm
_override_setting = 'PROJECT_RELATIONSHIP_FORM'
Copy link

@agjohnson agjohnson Apr 11, 2018

We don't use individual settings anymore, this is legacy. See the override classes setting instead.

@@ -563,6 +569,11 @@ def save(self):
return project

class TranslationForm(SettingsOverrideObject):
_default_class = TranslationBaseForm
_override_setting = 'PROJECT_TRANSLATION_FORM'
Copy link

@agjohnson agjohnson Apr 11, 2018

Same here

@agjohnson agjohnson added this to the 2.4 milestone Apr 11, 2018
@agjohnson agjohnson merged commit 6bd1c68 into master Apr 12, 2018
1 check passed
@agjohnson agjohnson deleted the humitos/corporate/extend-forms branch Apr 12, 2018
xrmx added a commit to italia/ that referenced this issue Apr 17, 2018

* Allow extend Translation and Subproject form logic from corporate

* Remove old style setting override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants