Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap notifications HTML code into a block #4273

Merged
merged 1 commit into from Jun 21, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 19, 2018

This block is override in error pages to be none and do not show notifications on these pages.

Related work in corporate site https://github.com/rtfd/readthedocs-corporate/pull/356

This block is override in error pages to be none and do not show
notifications on these pages.
@humitos humitos requested a review from a team June 19, 2018 20:09
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough 👍

@ericholscher ericholscher merged commit ae9d47c into master Jun 21, 2018
@humitos humitos deleted the humitos/notifications/error-pages branch June 22, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants