Merge pull request #4273 from rtfd/humitos/notifications/error-pages

Wrap notifications HTML code into a block
readthedocs · Jun 21, 2018 · ae9d47c · ae9d47c
2 parents 303d3a4 + a341a44
commit ae9d47c
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 15 deletions.
diff --git a/readthedocs/templates/401.html b/readthedocs/templates/401.html
@@ -10,6 +10,8 @@
   {% include "error_header.html" %}
 {% endblock %}
 
+{% block notify %}{% endblock %}
+
 {# Hide the language select form so we don't set a CSRF cookie #}
 {% block language-select-form %}{% endblock %}
 

diff --git a/readthedocs/templates/404.html b/readthedocs/templates/404.html
@@ -10,6 +10,8 @@
   {% include "error_header.html" %}
 {% endblock %}
 
+{% block notify %}{% endblock %}
+
 {# Hide the language select form so we don't set a CSRF cookie #}
 {% block language-select-form %}{% endblock %}
 

diff --git a/readthedocs/templates/500.html b/readthedocs/templates/500.html
@@ -1,13 +1,15 @@
 {% extends "base.html" %}
 {% load i18n %}
 
-    {% block title %}
-      {% trans "Server Error" %}
-    {% endblock %}
+{% block title %}
+  {% trans "Server Error" %}
+{% endblock %}
+
+{% block header-wrapper %}
+  {% include "error_header.html" %}
+{% endblock %}
 
-    {% block header-wrapper %}
-      {% include "error_header.html" %}
-    {% endblock %}
+{% block notify %}{% endblock %}
 
 {# Hide the language select form so we don't set a CSRF cookie #}
 {% block language-select-form %}{% endblock %}

diff --git a/readthedocs/templates/base.html b/readthedocs/templates/base.html
@@ -84,15 +84,19 @@
     <div id="content">
       <div class="wrapper">
 
-        {% if messages %}
-          <ul class="notifications">
-            {% for message in messages %}
-              <li class="notification notification-{{ message.level }}" {% if message.pk %}data-dismiss-url="{% url 'message_mark_read' message.pk %}{% endif %}">
-                {{ message }}
-              </li>
-            {% endfor %}
-          </ul>
-        {% endif %}
+        <!-- BEGIN notify -->
+        {% block notify %}
+          {% if messages %}
+            <ul class="notifications">
+              {% for message in messages %}
+                <li class="notification notification-{{ message.level }}" {% if message.pk %}data-dismiss-url="{% url 'message_mark_read' message.pk %}{% endif %}">
+                  {{ message }}
+                </li>
+              {% endfor %}
+            </ul>
+          {% endif %}
+        {% endblock %}
+        <!-- END notify -->
 
         {% block content-header %}
         {% endblock %}