Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit 2018-08-01: I removed the actual storage backends. They will be used in a separate repository with deployment customizations. This PR is now relatively minor.
This builds on #4427. This can be merged into that branch or into master and that one can be closed.
readthedocs/core/storage.py
should be in this repository and not in our extensions. I don't think it is particularly useful to anyone and is particular to our deploy process.readthedocs/settings/base.py
. I think that in dev the default Django storage is fine. This should only be used in prod.Testing
Install dependencies
Set settings (
readthedocs/settings/base.py
or other appropriate settings)Collect static files