Allow filtering builds by commit. #4831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cs.org into filter-builds-by-commit
Codecov Report
@@ Coverage Diff @@
## master #4831 +/- ##
======================================
Coverage 76.2% 76.2%
======================================
Files 158 158
Lines 10022 10022
Branches 1265 1265
======================================
Hits 7637 7637
Misses 2041 2041
Partials 344 344
|
humitos
approved these changes
Oct 31, 2018
| @@ -243,7 +243,7 @@ class BuildViewSetBase(UserSelectViewSet): | |||
| serializer_class = BuildSerializer | |||
| admin_serializer_class = BuildAdminSerializer | |||
| model = Build | |||
| filter_fields = ('project__slug',) | |||
| filter_fields = ('project__slug', 'commit') | |||
There was a problem hiding this comment.
The commit has is not unique, so by querying only by commit you could receive 2 builds from different projects. I suppose that if the user cares about that, will also apply the filter project__slug.
I'm assuming that we are fine.
|
Ups! I approved it but I forgot to mention that we should add this to our docs: https://docs.readthedocs.io/en/latest/api/v2.html#builds |
|
There is a section there for "Query Parameters" |
|
Good catch. Will add it. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #3544
Fixes #872