Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modified_date to ImportedFile. #4850

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Nov 1, 2018

This makes it easier to see when files have been updated so we can reindex smarter.

This is also in our search refactor, and I want to standardize the DB so we don't have a migration necessary on that branch.

@ericholscher ericholscher requested review from a team and safwanrahman November 1, 2018 19:37
This makes it easier to see when files have been updated so we can reindex smarter
@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #4850 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4850      +/-   ##
==========================================
+ Coverage   76.41%   76.41%   +<.01%     
==========================================
  Files         158      158              
  Lines        9990     9991       +1     
  Branches     1262     1262              
==========================================
+ Hits         7634     7635       +1     
  Misses       2016     2016              
  Partials      340      340
Impacted Files Coverage Δ
readthedocs/projects/models.py 85.53% <100%> (+0.03%) ⬆️

@ericholscher
Copy link
Member Author

ping @rtfd/core -- simple change, but it will make the search migrations easier.

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also, you may be interested in checking #4864

@ericholscher ericholscher merged commit a6120f4 into master Nov 5, 2018
@stsewd stsewd deleted the add-modified-date-importedfile branch November 5, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants