Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade stripe Python package to the latest version #4904

Merged
merged 1 commit into from Nov 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion readthedocs/gold/forms.py
Expand Up @@ -69,7 +69,7 @@ def get_subscription(self):
customer = self.get_customer()

# TODO get the first subscription more intelligently
subscriptions = customer.subscriptions.all(limit=5)
subscriptions = customer.subscriptions.list(limit=5)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if subscriptions.data:
# Update an existing subscription - Stripe prorates by default
subscription = subscriptions.data[0]
Expand Down
2 changes: 1 addition & 1 deletion readthedocs/gold/tests/test_forms.py
Expand Up @@ -222,7 +222,7 @@ def test_update_subscription_plan(self):
mock.ANY,
mock.ANY),
mock.call('post',
'/v1/customers/cus_12345/subscriptions/sub_12345',
'/v1/subscriptions/sub_12345',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{'source': mock.ANY, 'plan': 'v1-org-5'},
mock.ANY),
])
2 changes: 1 addition & 1 deletion readthedocs/payments/forms.py
Expand Up @@ -5,7 +5,7 @@
from builtins import object
import logging

from stripe.resource import Customer, Charge
from stripe import Customer, Charge
from stripe.error import InvalidRequestError
from django import forms
from django.utils.translation import ugettext_lazy as _
Expand Down
5 changes: 1 addition & 4 deletions requirements/pip.txt
Expand Up @@ -82,10 +82,7 @@ beautifulsoup4==4.6.3
Unipath==1.1
django-kombu==0.9.4
mock==2.0.0

# stripe 1.20.2 is the latest compatible with our code base (otherwise
# gold/tests/test_forms.py fails)
stripe==1.20.2
stripe==2.12.0

django-formtools==2.1

Expand Down