Remove trailing slashes on svn checkout

readthedocs/rtd_tests/tests/test_backend_svn.py

@@ -0,0 +1,36 @@
+# -*- coding: utf-8 -*-
+"""Tests For SVN"""
+
+from __future__ import (
+    absolute_import,
+    division,
+    print_function,
+    unicode_literals,
+)
+
+from mock import patch
+from django_dynamic_fixture import get
+
+from readthedocs.rtd_tests.base import RTDTestCase
+from readthedocs.projects.models import Project
+from readthedocs.builds.models import Version
+from readthedocs.vcs_support.backends.svn import Backend as SvnBackend
+
+class TestSvnBackend(RTDTestCase):
+
+    def test_get_url(self):
+        project = get(Project)
+        version = get(Version, project=project)
+        backend_obj = SvnBackend(project, version.slug)
+
+        base = 'http://example.com/'
+        tag = 'xyz/'
+        self.assertEqual(backend_obj.get_url(base, tag), 'http://example.com/xyz/')
+
+        base = 'http://example.com/'
+        tag = '/xyz/'
+        self.assertEqual(backend_obj.get_url(base, tag), 'http://example.com/xyz/')
+
+        base = 'http://example.com'
+        tag = '/xyz/'
+        self.assertEqual(backend_obj.get_url(base, tag), 'http://example.com/xyz/')

readthedocs/vcs_support/backends/svn.py

@@ -58,7 +58,7 @@ def up(self):
     def co(self, identifier=None):
         self.make_clean_working_dir()
         if identifier:
-            url = self.base_url + identifier
+            url = self.get_url(self.base_url, identifier)
         else:
             url = self.repo_url
         retcode, out, err = self.run('svn', 'checkout', url, '.')
@@ -104,3 +104,9 @@ def commit(self):
     def checkout(self, identifier=None):
         super(Backend, self).checkout()
         return self.co(identifier)
+
+    def get_url(self, base_url, identifier):
+        base = base_url.rstrip('/')
+        tag = identifier.lstrip('/')
+        url = '{}/{}'.format(base, tag)
+        return url